[webkit-reviews] review granted: [Bug 221225] Implement WebXR getViewerPose and getPose : [Attachment 420660] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Imanol Fernandez
<ifernandez at igalia.com>'s request for review:
Bug 221225: Implement WebXR getViewerPose and getPose
https://bugs.webkit.org/show_bug.cgi?id=221225

Attachment 420660: Patch

https://bugs.webkit.org/attachment.cgi?id=420660&action=review




--- Comment #22 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 420660
  --> https://bugs.webkit.org/attachment.cgi?id=420660
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420660&action=review

> Source/WebCore/Modules/webxr/WebXRFrame.cpp:134
> +    const bool emulatedPosition = m_data.isPositionEmulated ||
!m_data.isPositionValid;

why const bool?

> Source/WebCore/Modules/webxr/WebXRSession.cpp:60
> +    , m_viewerReferenceSpace(new WebXRViewerSpace(document, *this))

makeUnique<WebXRViewerSpace>(document, this)

> Source/WebCore/Modules/webxr/WebXRSpace.h:58
>      ScriptExecutionContext* scriptExecutionContext() const override { return
ContextDestructionObserver::scriptExecutionContext(); }

final?

> Source/WebCore/Modules/webxr/WebXRSpace.h:60
> +    Ref<WebXRRigidTransform> m_originOffset;

Can we make it private and add a protected WebXRRigidTransform& getter?

> Source/WebCore/Modules/webxr/WebXRSpace.h:81
> +    void derefEventTarget() final { RELEASE_ASSERT_NOT_REACHED(); }

This is fine like this. Otherwise, you could do
m_session.ref()/m_session.deref();