[webkit-reviews] review granted: [Bug 222089] Return correct target for App Highlight menus. : [Attachment 420784] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 17 19:35:06 PST 2021


Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 222089: Return correct target for App Highlight menus.
https://bugs.webkit.org/show_bug.cgi?id=222089

Attachment 420784: Patch

https://bugs.webkit.org/attachment.cgi?id=420784&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 420784
  --> https://bugs.webkit.org/attachment.cgi?id=420784
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420784&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3699
> +    if (sel_isEqual(action,
@selector(createHighlightInCurrentGroupWithRange:)) || sel_isEqual(action,
@selector(createHighlightInNewGroupWithRange:)))

You can just use == (see above, or see the sel_isEqual docs)


More information about the webkit-reviews mailing list