[webkit-reviews] review canceled: [Bug 222007] Web Inspector: Implement Grid Overlay "Show track sizes" drawing : [Attachment 420686] WIP v0.1 - First pass
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 17 11:47:46 PST 2021
Patrick Angle <pangle at apple.com> has canceled Patrick Angle
<pangle at apple.com>'s request for review:
Bug 222007: Web Inspector: Implement Grid Overlay "Show track sizes" drawing
https://bugs.webkit.org/show_bug.cgi?id=222007
Attachment 420686: WIP v0.1 - First pass
https://bugs.webkit.org/attachment.cgi?id=420686&action=review
--- Comment #3 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 420686
--> https://bugs.webkit.org/attachment.cgi?id=420686
WIP v0.1 - First pass
This is a first pass, but has a big flaw which is that using the GridTrackSize
doesn't give us access to the actual value that was authored in all cases. For
example, using `vw` units in a track size will be resolved to pixels by the
time we read it here. Probably need to use the actual `CSSValue` instead to
figure this out.
More information about the webkit-reviews
mailing list