[webkit-reviews] review granted: [Bug 222008] [iOS][FCR] Add new datalist dropdown for text inputs : [Attachment 420557] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 17 11:13:20 PST 2021

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 222008: [iOS][FCR] Add new datalist dropdown for text inputs

Attachment 420557: Patch


--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 420557
  --> https://bugs.webkit.org/attachment.cgi?id=420557

View in context: https://bugs.webkit.org/attachment.cgi?id=420557&action=review

> Source/WebCore/html/TextFieldInputType.h:139
> +    bool shouldOnlyShowDataListDropdownButtonWhenFocusedOrEdited();

Nit - we should mark this `const` now that it's an instance method.

> Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm:175
> +    if (_page)
> +	   _page->selectDataListOptionForTesting(optionIndex);
> +#endif

Hm…I think ideally, the testing-only code should simulate interactions by
invoking methods on UI objects (e.g. WKDataListSuggestionsDropdown). Though, if
there's no clear simple way to achieve that, this is fine too.

More information about the webkit-reviews mailing list