[webkit-reviews] review denied: [Bug 222048] Use element fullscreen for video on some configurations : [Attachment 420664] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 17 10:26:42 PST 2021


Sam Weinig <sam at webkit.org> has denied Dean Jackson <dino at apple.com>'s request
for review:
Bug 222048: Use element fullscreen for video on some configurations
https://bugs.webkit.org/show_bug.cgi?id=222048

Attachment 420664: Patch

https://bugs.webkit.org/attachment.cgi?id=420664&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 420664
  --> https://bugs.webkit.org/attachment.cgi?id=420664
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420664&action=review

> Source/WTF/wtf/PlatformEnableCocoa.h:549
> +#if !defined(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) && (PLATFORM(MAC) &&
HAVE(UIKIT_WEBKIT_INTERNALS)

This should be 

#if !defined(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) && (PLATFORM(MAC) ||
HAVE(UIKIT_WEBKIT_INTERNALS))


More information about the webkit-reviews mailing list