[webkit-reviews] review granted: [Bug 221641] Expand stubs to thread actual NSURLRequest/NSURLResponse for the new simulated-request API : [Attachment 420573] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 17 10:15:17 PST 2021


Chris Dumez <cdumez at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 221641: Expand stubs to thread actual NSURLRequest/NSURLResponse for the
new simulated-request API
https://bugs.webkit.org/show_bug.cgi?id=221641

Attachment 420573: Patch

https://bugs.webkit.org/attachment.cgi?id=420573&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 420573
  --> https://bugs.webkit.org/attachment.cgi?id=420573
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420573&action=review

>> Source/WebKit/UIProcess/WebPageProxy.cpp:1501
>> +void
WebPageProxy::loadSimulatedRequestDataWithNavigationShared(Ref<WebProcessProxy>
&& process, WebCore::PageIdentifier webPageID, API::Navigation& navigation,
WebCore::ResourceRequest&& simulatedRequest, WebCore::ResourceResponse&&
simulatedResponse, const IPC::DataReference& data, API::Object* userData,
ShouldTreatAsContinuingLoad shouldTreatAsContinuingLoad,
Optional<NavigatingToAppBoundDomain> isNavigatingToAppBoundDomain,
Optional<WebsitePoliciesData>&& websitePolicies, ShouldOpenExternalURLsPolicy
shouldOpenExternalURLsPolicy)
> 
> @Chris: I can merge this with the above if I don’t need to do a
ProvisionalPageProxy.

Right. I think we should merge.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm:100
> +    EXPECT_EQ((NSUInteger)1, list.backList.count);

Would be good to check WKBackForwardListItem.URL too for both the current item
and the backList item.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm:111
> +    EXPECT_EQ((NSUInteger)1, list.forwardList.count);

ditto.


More information about the webkit-reviews mailing list