[webkit-reviews] review granted: [Bug 222036] Animated keyframe style needs to go through full style adjuster : [Attachment 420642] patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 222036: Animated keyframe style needs to go through full style adjuster
https://bugs.webkit.org/show_bug.cgi?id=222036

Attachment 420642: patch

https://bugs.webkit.org/attachment.cgi?id=420642&action=review




--- Comment #4 from zalan <zalan at apple.com> ---
Comment on attachment 420642
  --> https://bugs.webkit.org/attachment.cgi?id=420642
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420642&action=review

> Source/WebCore/style/StyleAdjuster.cpp:-589
> -    bool elementRespectsZIndex = style.position() != PositionType::Static ||
(parentBoxStyle && parentBoxStyle->isDisplayFlexibleOrGridBox());
> -
> -    if (elementRespectsZIndex && !style.hasAutoSpecifiedZIndex())
> -	   style.setUsedZIndex(style.specifiedZIndex());
> -    else if (impact.contains(AnimationImpact::ForcesStackingContext))

I assume this is taken care of in Adjuster::adjust() now.

> Source/WebCore/style/StyleAdjuster.h:49
> +    void adjustAnimatedStyle(RenderStyle&, OptionSet<AnimationImpact>);

const?