[webkit-reviews] review granted: [Bug 222014] Change App Highlight delegate to pass more information about the highlight for display. : [Attachment 420614] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 222014: Change App Highlight delegate to pass more information about the
highlight for display.
https://bugs.webkit.org/show_bug.cgi?id=222014

Attachment 420614: Patch

https://bugs.webkit.org/attachment.cgi?id=420614&action=review




--- Comment #11 from Tim Horton <thorton at apple.com> ---
Comment on attachment 420614
  --> https://bugs.webkit.org/attachment.cgi?id=420614
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420614&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1434
> +    if ([delegate
respondsToSelector:@selector(_webView:storeAppHighlight:inNewGroup:)])

You should probably just bail at the top, none of this work is worth anything
if you're not going to call the delegate.

> Source/WebKit/UIProcess/API/Cocoa/_WKAppHighlight.h:41
> + at property (nonatomic, readonly, copy) NSString * text;

* is a-floating

> Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm:29
> +

This extraneous newline is still here