[webkit-reviews] review granted: [Bug 221917] [macOS] Introduce a new context menu item to preview images : [Attachment 420423] Rebaseline test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 16 19:29:19 PST 2021


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 221917: [macOS] Introduce a new context menu item to preview images
https://bugs.webkit.org/show_bug.cgi?id=221917

Attachment 420423: Rebaseline test

https://bugs.webkit.org/attachment.cgi?id=420423&action=review




--- Comment #10 from Tim Horton <thorton at apple.com> ---
Comment on attachment 420423
  --> https://bugs.webkit.org/attachment.cgi?id=420423
Rebaseline test

View in context: https://bugs.webkit.org/attachment.cgi?id=420423&action=review

> Source/WebKit/ChangeLog:15
> +	   Link against Quartz and UniformTypeIdentifiers.

LIES

> Source/WebKit/ChangeLog:29
> +	   Add a non-const version of `webHitTestResultData()`, so that we can
generate a `CGImage` using
> +	   `WebHitTestResultData`'s bitmap data.

So confused why this needs non-const hit test result data


More information about the webkit-reviews mailing list