[webkit-reviews] review granted: [Bug 221802] Change App Highlights API to operate in terms of a single serialized highlight at a time : [Attachment 420479] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 221802: Change App Highlights API to operate in terms of a single
serialized highlight at a time
https://bugs.webkit.org/show_bug.cgi?id=221802

Attachment 420479: Patch

https://bugs.webkit.org/attachment.cgi?id=420479&action=review




--- Comment #23 from Tim Horton <thorton at apple.com> ---
Comment on attachment 420479
  --> https://bugs.webkit.org/attachment.cgi?id=420479
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420479&action=review

> Source/WebCore/Headers.cmake:50
> +    Modules/highlight/AppHighlightInformation.h

You could totally drop the "Information" without losing any "information" ��‍♂️

> Source/WebCore/page/ChromeClient.h:25
> +#include "AppHighlightInformation.h"

Please forward declare, this header is included eeeeeverywhere