[webkit-reviews] review granted: [Bug 221895] [selectors] :focus-visible parsing and experimental flag : [Attachment 420321] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 16 10:21:05 PST 2021
Darin Adler <darin at apple.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 221895: [selectors] :focus-visible parsing and experimental flag
https://bugs.webkit.org/show_bug.cgi?id=221895
Attachment 420321: Patch
https://bugs.webkit.org/attachment.cgi?id=420321&action=review
--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 420321
--> https://bugs.webkit.org/attachment.cgi?id=420321
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=420321&action=review
> Source/WebCore/css/SelectorCheckerTestFunctions.h:480
> + if (InspectorInstrumentation::forcePseudoState(element,
CSSSelector::PseudoClassFocusVisible))
> + return true;
> +
> + return false;
Should just be a return statement, no need for if true else false.
> LayoutTests/imported/w3c/ChangeLog:8
> + Update expectations as now :focus-visible is a valid selector.
Is this because the feature is on for regression tests? Or do these changes
happen with the feature still off?
If the latter, I am worried that even these small changes could cause
compatibility problems.
More information about the webkit-reviews
mailing list