[webkit-reviews] review granted: [Bug 221938] [iOS] the tracks button should be emphasized while the media controls context menu is showing : [Attachment 420397] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 221938: [iOS] the tracks button should be emphasized while the media
controls context menu is showing
https://bugs.webkit.org/show_bug.cgi?id=221938

Attachment 420397: Patch

https://bugs.webkit.org/attachment.cgi?id=420397&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 420397
  --> https://bugs.webkit.org/attachment.cgi?id=420397
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420397&action=review

> Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:340
> +    if (m_showMediaControlsContextMenuCallback)
> +	   return false;

If this condition is an error, it could be useful to have an ASSERT.