[webkit-reviews] review granted: [Bug 221914] Reduce explicit usage of [objC release] in WebKit even more : [Attachment 420379] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 16 09:31:40 PST 2021
Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 221914: Reduce explicit usage of [objC release] in WebKit even more
https://bugs.webkit.org/show_bug.cgi?id=221914
Attachment 420379: Patch
https://bugs.webkit.org/attachment.cgi?id=420379&action=review
--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 420379
--> https://bugs.webkit.org/attachment.cgi?id=420379
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=420379&action=review
> Source/WebKitLegacy/mac/History/WebHistory.mm:664
> + _sharedHistory = retainPtr(history).leakRef();
I think it would be nicer to change the type of _sharedHistory to a
function-scoped NeverDestroyed<RetainPtr>
> Source/WebKitLegacy/mac/Plugins/WebPluginDatabase.mm:195
> + auto oldPaths = adoptNS(additionalWebPlugInPaths);
Ditto. additionalWebPlugInPaths should be a RetainPtr.
More information about the webkit-reviews
mailing list