[webkit-reviews] review granted: [Bug 173471] WebAssembly: implement non-trapping float to int conversion : [Attachment 420469] Patch

[bugzilla-daemon at webkit.org]

Tadeu Zagallo <tzagallo at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 173471: WebAssembly: implement non-trapping float to int conversion
https://bugs.webkit.org/show_bug.cgi?id=173471

Attachment 420469: Patch

https://bugs.webkit.org/attachment.cgi?id=420469&action=review




--- Comment #10 from Tadeu Zagallo <tzagallo at apple.com> ---
Comment on attachment 420469
  --> https://bugs.webkit.org/attachment.cgi?id=420469
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420469&action=review

r=me

> Source/JavaScriptCore/llint/WebAssembly.asm:1376
> +    move 0xcf000000, t0 # INT32_MIN (Note that INT32_MIN - 1.0 in float is
the same as INT32_MIN in float).

why not use constexpr here?