[webkit-reviews] review canceled: [Bug 221802] Change App Highlights API to operate in terms of a single serialized highlight at a time : [Attachment 420415] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has canceled Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 221802: Change App Highlights API to operate in terms of a single
serialized highlight at a time
https://bugs.webkit.org/show_bug.cgi?id=221802

Attachment 420415: Patch

https://bugs.webkit.org/attachment.cgi?id=420415&action=review




--- Comment #19 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 420415
  --> https://bugs.webkit.org/attachment.cgi?id=420415
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420415&action=review

I only commented on one decoder but please double check the other ones.

> Source/WebCore/Modules/highlight/AppHighlightRangeData.cpp:84
> +    Optional<uint64_t> pathIndex;

Watch out, the types need to match in the encoders and the decoders. You
encoded an unsigned and decoding a uint64 here. This should use unsigned here
to match.

> Source/WebCore/Modules/highlight/AppHighlightRangeData.cpp:89
> +    return {{ WTFMove(*identifier), WTFMove(*nodeName), WTFMove(*textData),
static_cast<unsigned>(*pathIndex) }};

Then the cast here would no longer be needed.