[webkit-reviews] review granted: [Bug 221927] BytecodeGenerator::fuseCompareAndJump() fails for some language constructs : [Attachment 420376] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 221927: BytecodeGenerator::fuseCompareAndJump() fails for some language
constructs
https://bugs.webkit.org/show_bug.cgi?id=221927

Attachment 420376: Patch

https://bugs.webkit.org/attachment.cgi?id=420376&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 420376
  --> https://bugs.webkit.org/attachment.cgi?id=420376
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420376&action=review

r=me, awesome!

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:5176
> +		   emitJumpIfTrue(emitEqualityOp<OpBeloweq>(newTemporary(),
context.completionTypeRegister(), emitLoad(nullptr, CompletionType::Throw)),
isThrowOrNormalLabel.get());

I think emitEqualityOp is not correct for OpBeloweq (emitBinaryOp?).
Could you also insert static_assert for them in emitEqualityOp? (static_assert
for EqOp is StrictEq etc.).