[webkit-reviews] review granted: [Bug 221942] EventHandler::updateSelectionForMouseDownDispatchingSelectStart should not use an orphaned selection : [Attachment 420414] Fixed release builds
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 15 19:07:29 PST 2021
Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 221942: EventHandler::updateSelectionForMouseDownDispatchingSelectStart
should not use an orphaned selection
https://bugs.webkit.org/show_bug.cgi?id=221942
Attachment 420414: Fixed release builds
https://bugs.webkit.org/attachment.cgi?id=420414&action=review
--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 420414
--> https://bugs.webkit.org/attachment.cgi?id=420414
Fixed release builds
View in context: https://bugs.webkit.org/attachment.cgi?id=420414&action=review
r=me (assuming EWS is green)
>
LayoutTests/editing/selection/click-selection-with-selectstart-node-removal.htm
l:32
> + const boundingRect = editor.getBoundingClientRect();
> + const x = boundingRect.x + 10;
> + const y = boundingRect.y + 10;
> + UIHelper.activateAndWaitForInputSessionAt(x, y);
Nit - can we just `UIHelper.activateElement(editor);` here?
More information about the webkit-reviews
mailing list