[webkit-reviews] review granted: [Bug 221936] [ARM64] Change break instruction comment to indicate possible security failure : [Attachment 420394] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 15 16:43:22 PST 2021


Mark Lam <mark.lam at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 221936: [ARM64] Change break instruction comment to indicate possible
security failure
https://bugs.webkit.org/show_bug.cgi?id=221936

Attachment 420394: Patch

https://bugs.webkit.org/attachment.cgi?id=420394&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 420394
  --> https://bugs.webkit.org/attachment.cgi?id=420394
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420394&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +	   using the same value the compiler emits.

nit: I would say "C++ compiler" to be more explicit especially since there are
so many compilers in our domain.


More information about the webkit-reviews mailing list