[webkit-reviews] review granted: [Bug 221871] Web Inspector: Add a way to wake up debuggables to the remote inspector protocol : [Attachment 420385] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 221871: Web Inspector: Add a way to wake up debuggables to the remote
inspector protocol
https://bugs.webkit.org/show_bug.cgi?id=221871

Attachment 420385: Patch

https://bugs.webkit.org/attachment.cgi?id=420385&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 420385
  --> https://bugs.webkit.org/attachment.cgi?id=420385
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420385&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKAutomationDelegate.h:39
> +// FIXME: Consider renaming WebKit::AutomationClient and
_WKAutomationDelegate to _WKInspectorDelegate since it isn't only used for
automation now. http://webkit.org/b/221933

NIT: I'd put this in `RemoteInspector::receivedWakeUpDebuggables` and
`AutomationClient::requestedDebuggablesToWakeUp` too so that it's more visible
and less likely to be missed/forgotten :)