[webkit-reviews] review granted: [Bug 221920] [GPUP] Ignore an IPC message if the message receiver has been destroyed : [Attachment 420358] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 15 14:04:33 PST 2021


Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 221920: [GPUP] Ignore an IPC message if the message receiver has been
destroyed
https://bugs.webkit.org/show_bug.cgi?id=221920

Attachment 420358: Patch

https://bugs.webkit.org/attachment.cgi?id=420358&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 420358
  --> https://bugs.webkit.org/attachment.cgi?id=420358
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420358&action=review

> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:110
> +Logger& GPUProcessConnection::logger()
> +{
> +    if (!m_logger)
> +	   m_logger = Logger::create(this);
> +
> +    return *m_logger;
> +}
> +

It looks like this is unused, `RELEASE_LOG_ERROR` does not use a Logger.


More information about the webkit-reviews mailing list