[webkit-reviews] review granted: [Bug 221861] [results.webkit.org] Distinguish hash and revision : [Attachment 420324] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 221861: [results.webkit.org] Distinguish hash and revision
https://bugs.webkit.org/show_bug.cgi?id=221861

Attachment 420324: Patch

https://bugs.webkit.org/attachment.cgi?id=420324&action=review




--- Comment #6 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 420324
  --> https://bugs.webkit.org/attachment.cgi?id=420324
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420324&action=review

> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/commit.py:70
> +	   if re.match(r'[0-9]+$', self.id):

Might be good to make this re a variable, like RE_SVN_REVISION

> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/commit.py:73
> +	   elif re.match(r'[a-fA-F0-9]+$', self.id):

Might be good to make this re a variable, like RE_GIT_HASH