[webkit-reviews] review granted: [Bug 221886] Cleanup exit/enterFullScreenHandler and how the global states are set. : [Attachment 420270] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 15 08:43:00 PST 2021
Darin Adler <darin at apple.com> has granted Jean-Yves Avenard [:jya]
<jya at apple.com>'s request for review:
Bug 221886: Cleanup exit/enterFullScreenHandler and how the global states are
set.
https://bugs.webkit.org/show_bug.cgi?id=221886
Attachment 420270: Patch
https://bugs.webkit.org/attachment.cgi?id=420270&action=review
--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 420270
--> https://bugs.webkit.org/attachment.cgi?id=420270
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=420270&action=review
> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h:236
> + void exitFullscreenHandler(BOOL success, NSError *, NextActions =
NextActions());
> + void enterFullscreenHandler(BOOL success, NSError *, NextActions =
NextActions());
Could consider { } instead of NextActions()
More information about the webkit-reviews
mailing list