[webkit-reviews] review granted: [Bug 221877] Improve readability in RenderFlexibleBox::childIntrinsicLogicalWidth : [Attachment 420250] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 15 01:46:45 PST 2021


Sergio Villar Senin <svillar at igalia.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 221877: Improve readability in
RenderFlexibleBox::childIntrinsicLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=221877

Attachment 420250: Patch

https://bugs.webkit.org/attachment.cgi?id=420250&action=review




--- Comment #2 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 420250
  --> https://bugs.webkit.org/attachment.cgi?id=420250
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420250&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:491
> +    Optional<LayoutUnit> childOverrideWidth;

Nit: override -> overriding (we have recently switched the naming)


More information about the webkit-reviews mailing list