[webkit-reviews] review granted: [Bug 221872] [JSC] PropertySlot should allow passing custom setters : [Attachment 420233] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 221872: [JSC] PropertySlot should allow passing custom setters
https://bugs.webkit.org/show_bug.cgi?id=221872

Attachment 420233: Patch

https://bugs.webkit.org/attachment.cgi?id=420233&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 420233
  --> https://bugs.webkit.org/attachment.cgi?id=420233
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420233&action=review

r=me

> Source/JavaScriptCore/runtime/VM.cpp:-391
> -    , customGetterSetterFunctionMap(*this)

Nice

> Source/JavaScriptCore/runtime/VM.cpp:1485
> +DYNAMIC_ISO_SUBSPACE_DEFINE_MEMBER_SLOW(customGetterFunctionSpace,
cellHeapCellType.get(), JSCustomGetterFunction) // Hash:0x18091000

This hash (// Hash:0x18091000) should be changed. So let's drop it.