[webkit-reviews] review granted: [Bug 219010] [WPE][GTK] SleepDisabler does not inhibit sleep with bubblewrap sandbox enabled: need to run xdg-dbus-proxy under bwrap or xdg-desktop-portal does not read our app ID : [Attachment 419638] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 13 14:48:08 PST 2021
Patrick Griffis <pgriffis at igalia.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 219010: [WPE][GTK] SleepDisabler does not inhibit sleep with bubblewrap
sandbox enabled: need to run xdg-dbus-proxy under bwrap or xdg-desktop-portal
does not read our app ID
https://bugs.webkit.org/show_bug.cgi?id=219010
Attachment 419638: Patch
https://bugs.webkit.org/attachment.cgi?id=419638&action=review
--- Comment #14 from Patrick Griffis <pgriffis at igalia.com> ---
Comment on attachment 419638
--> https://bugs.webkit.org/attachment.cgi?id=419638
Patch
Overall this looks good to me. I'm also not sure why the runtime dir permission
is needed but I also agree its a trusted process.
More information about the webkit-reviews
mailing list