[webkit-reviews] review granted: [Bug 221868] Reduce requirements for color types to only conversion to their reference color : [Attachment 420223] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 221868: Reduce requirements for color types to only conversion to their
reference color
https://bugs.webkit.org/show_bug.cgi?id=221868

Attachment 420223: Patch

https://bugs.webkit.org/attachment.cgi?id=420223&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 420223
  --> https://bugs.webkit.org/attachment.cgi?id=420223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420223&action=review

> Source/WebCore/ChangeLog:30
> +			   â â â â â â â â â â â â â â â â â â â¼ â â â â â â â
â â â â â â â â â â â â â â â â â â â â â â â â â â â

"ASCII art" that uses UTF-8, eh?

> Source/WebCore/platform/graphics/ColorConversion.h:269
> +	   // results (due to floating point effects) so if this optimation is
considered we should ensure we

Typo in "optimization" here.

> Source/WebCore/platform/graphics/ColorMatrix.h:56
> +template<size_t Columns, size_t Rows>

I prefer not to name counts as if they were objects. "Columns" sounds like it
is a collection of columns. Maybe ColumnCount?

This comes up a lot in argument names, not just template arguments.