[webkit-reviews] review granted: [Bug 221805] [JSC] Enable JITCage on macOS : [Attachment 420208] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 221805: [JSC] Enable JITCage on macOS
https://bugs.webkit.org/show_bug.cgi?id=221805

Attachment 420208: Patch

https://bugs.webkit.org/attachment.cgi?id=420208&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 420208
  --> https://bugs.webkit.org/attachment.cgi?id=420208
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420208&action=review

LGTM but it would be good to get more reviewers to take a look at this.

> Source/JavaScriptCore/ChangeLog:10
> +	   We need to add this entitlement only when building it on macOS
120000 or upper version.

/upper/higher/

> Source/JavaScriptCore/ChangeLog:14
> +	   This patch follows to r248164's way: we must not use
CODE_SIGN_ENTITLEMENTS because XCode inserts implicit code-signing

/follows to r248164/follows r248164/

> Source/WTF/ChangeLog:9
> +	   Enable JIT_CAGE when macOS is 120000 or upper with ARM64E.

/upper/higher/

> Source/WebKit/ChangeLog:9
> +	   We need to add this entitlement only when building it on macOS
120000 or upper version.

/upper/higher/

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:11345
> +			name = "Generate Entitlements";

Can this have a different name?  Maybe "Generate jsc Entitlements"?  Or does it
have to be this exact string?

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:11365
> +			name = "Generate Entitlements";

Ditto.	Maybe "Generate testapi entitlements"?