[webkit-reviews] review granted: [Bug 221859] [LayoutTests] Convert http/tests/svg convert PHP to Python : [Attachment 420194] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 12 17:06:37 PST 2021


Jonathan Bedard <jbedard at apple.com> has granted Chris Gambrell
<cgambrell at apple.com>'s request for review:
Bug 221859: [LayoutTests] Convert http/tests/svg convert PHP to Python
https://bugs.webkit.org/show_bug.cgi?id=221859

Attachment 420194: Patch

https://bugs.webkit.org/attachment.cgi?id=420194&action=review




--- Comment #3 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 420194
  --> https://bugs.webkit.org/attachment.cgi?id=420194
Patch

Looks good, although the comment concerns me a bit given we know that Python is
a little slower than PHP...passing EWS is probably sufficient to cover that,
though.


More information about the webkit-reviews mailing list