[webkit-reviews] review granted: [Bug 221743] [WebAuthn] Provide SPI to query local credentials : [Attachment 420171] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 221743: [WebAuthn] Provide SPI to query local credentials
https://bugs.webkit.org/show_bug.cgi?id=221743

Attachment 420171: Patch

https://bugs.webkit.org/attachment.cgi?id=420171&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 420171
  --> https://bugs.webkit.org/attachment.cgi?id=420171
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420171&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:165
> +	   (id)kSecClass: (id)kSecClassKey,

It's a shame so many casts are needed, but it looks like that's typical.

It looks like these are usually done as (__bridge id) in other code.

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:231
> +	   (id)kSecClass: (id)kSecClassKey,

Suggest (__bridge id)