[webkit-reviews] review denied: [Bug 221673] Page updates and rAF callbacks should run at a frequency close to 60Hz on high refresh-rate displays : [Attachment 420120] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 12 10:03:47 PST 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 221673: Page updates and rAF callbacks should run at a frequency close to
60Hz on high refresh-rate displays
https://bugs.webkit.org/show_bug.cgi?id=221673

Attachment 420120: Patch

https://bugs.webkit.org/attachment.cgi?id=420120&action=review




--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 420120
  --> https://bugs.webkit.org/attachment.cgi?id=420120
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420120&action=review

> Source/WebKit/UIProcess/mac/DisplayLink.cpp:79
> +void DisplayLink::setPreferredFramesPerSecond(WebCore::FramesPerSecond
preferredFramesPerSecond)
> +{
> +    m_preferredFramesPerSecond = preferredFramesPerSecond;
> +}

There is one DisplayLink per display, so you can't have clients push
preferredFramesPerSecond here.


More information about the webkit-reviews mailing list