[webkit-reviews] review granted: [Bug 221799] 'sync-commits.py' should be able to limit reporting scope to a specific branch on a Git repository. : [Attachment 420077] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 221799: 'sync-commits.py' should be able to limit reporting scope to a
specific branch on a Git repository.
https://bugs.webkit.org/show_bug.cgi?id=221799

Attachment 420077: Patch

https://bugs.webkit.org/attachment.cgi?id=420077&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 420077
  --> https://bugs.webkit.org/attachment.cgi?id=420077
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420077&action=review

I guess we don't have any tests for this script... We probably should.

> Websites/perf.webkit.org/tools/sync-commits.py:195
> -    def __init__(self, name, git_checkout, git_url):
> +    def __init__(self, name, git_checkout, git_url, git_branch):

should probably set the default parameter of None to signify the fact it's
optional.