[webkit-reviews] review granted: [Bug 221779] Review usage of adoptNS() : [Attachment 420042] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 11 14:14:14 PST 2021


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 221779: Review usage of adoptNS()
https://bugs.webkit.org/show_bug.cgi?id=221779

Attachment 420042: Patch

https://bugs.webkit.org/attachment.cgi?id=420042&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 420042
  --> https://bugs.webkit.org/attachment.cgi?id=420042
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420042&action=review

> Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:510
>	   [webAnimationDelegate setOwner:this];

If you use [m_delegate setOwner:this] instead, this can only be two lines.


More information about the webkit-reviews mailing list