[webkit-reviews] review granted: [Bug 221760] [WPE] event.ctrlKey and other are false in keydown event : [Attachment 420001] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 221760: [WPE] event.ctrlKey and other are false in keydown event
https://bugs.webkit.org/show_bug.cgi?id=221760

Attachment 420001: Patch

https://bugs.webkit.org/attachment.cgi?id=420001&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 420001
  --> https://bugs.webkit.org/attachment.cgi?id=420001
Patch

Other than a nit about the wording in the comment below, patch looks good. 
Thanks!

View in context: https://bugs.webkit.org/attachment.cgi?id=420001&action=review

> Source/WebKit/Shared/libwpe/WebEventFactory.cpp:64
> +    // to behave similar to other platforms and other browsers under X (see
http://crbug.com/127142#c8).

WPE itself does not strictly depend on X11; so I think it would be a bit more
appropriate to write something like “Handling of modifier masks in WPE is
modelled
after after X. This code makes WPE […]” ?