[webkit-reviews] review granted: [Bug 221677] Rework RGB color types to be more declarative to reduce code duplication and make progress toward better automatic conversion : [Attachment 419927] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 221677: Rework RGB color types to be more declarative to reduce code
duplication and make progress toward better automatic conversion
https://bugs.webkit.org/show_bug.cgi?id=221677

Attachment 419927: Patch

https://bugs.webkit.org/attachment.cgi?id=419927&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 419927
  --> https://bugs.webkit.org/attachment.cgi?id=419927
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419927&action=review

> Source/WebCore/ChangeLog:48
> +	   more places now, and the deduction guides we had been using don't
work, so we must explicitly specify

A little sad to lose the deduction guides.

> Source/WebCore/ChangeLog:54
> +	   intend to remove in a previous patch, but I am not actual sure is
necessary. While I work that out, 

Even though I am the one who pointed it out, I think it’s not necessary.