[webkit-reviews] review granted: [Bug 221725] [LFC][IFC] Introduce dedicated logical rect getter for each inline level box type : [Attachment 419937] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 11 06:25:48 PST 2021


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 221725: [LFC][IFC] Introduce dedicated logical rect getter for each inline
level box type
https://bugs.webkit.org/show_bug.cgi?id=221725

Attachment 419937: Patch

https://bugs.webkit.org/attachment.cgi?id=419937&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 419937
  --> https://bugs.webkit.org/attachment.cgi?id=419937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419937&action=review

>
Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp:344
> -	       auto inlineBoxRect =
lineBox.logicalMarginRectForInlineLevelBox(layoutBox, boxGeometry);
> +	       auto inlineBoxRect = lineBox.logicalRectForInlineBox(layoutBox,
boxGeometry);

nice!


More information about the webkit-reviews mailing list