[webkit-reviews] review granted: [Bug 221676] Returning sRGB from CG color space functions on failure is too error prone : [Attachment 419849] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 10 16:05:53 PST 2021


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 221676: Returning sRGB from CG color space functions on failure is too
error prone
https://bugs.webkit.org/show_bug.cgi?id=221676

Attachment 419849: Patch

https://bugs.webkit.org/attachment.cgi?id=419849&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 419849
  --> https://bugs.webkit.org/attachment.cgi?id=419849
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419849&action=review

> Source/WebCore/platform/graphics/cg/ColorSpaceCG.h:120
> +// NOTE: This function is guarenteed to return non-null, unlike
cachedNullableCGColorSpace().

Seems mysterious to not say *why* it’s guaranteed. The subtle difference
between DestinationColorSpace and ColorSpace. I’d say something like, "Since
this is for *destination* color spaces, this function is ..."

Also, the word guaranteed is misspelled!


More information about the webkit-reviews mailing list