[webkit-reviews] review granted: [Bug 220979] Complete XRSession::requestAnimationFrame implementation : [Attachment 419713] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 10 09:50:12 PST 2021


youenn fablet <youennf at gmail.com> has granted Imanol Fernandez
<ifernandez at igalia.com>'s request for review:
Bug 220979: Complete XRSession::requestAnimationFrame implementation
https://bugs.webkit.org/show_bug.cgi?id=220979

Attachment 419713: Patch

https://bugs.webkit.org/attachment.cgi?id=419713&action=review




--- Comment #24 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 419713
  --> https://bugs.webkit.org/attachment.cgi?id=419713
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419713&action=review

> Source/WebCore/Modules/webxr/WebXRSession.cpp:505
> +	       auto callbacks = m_callbacks;

Can we do:
auto callbacks = WTFMove(m_callbacks).

> Source/WebCore/Modules/webxr/WebXRSession.cpp:508
> +	       frame->setActive(true);

We went from a model where we were reusing the same frame over and over to
creating a new frame each time.
This is observable from JS so we should add a test for it.
And verify other browsers are doing the same.

> Source/WebCore/Modules/webxr/WebXRSession.cpp:527
> +	       });

Not needed if we can clear m_callbacks above.

> Source/WebCore/Modules/webxr/WebXRSystem.h:118
> +	   ScriptExecutionContext* m_scriptExecutionContext { nullptr };

This is probably incorrect. Let's make it a ContextDesutrctionObserver.

> Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp:205
> +    return WTF::switchOn(m_context, [](const
RefPtr<WebGLRenderingContextBase>& baseContext) {

What about #if ENABLE(WEBGL2)?


More information about the webkit-reviews mailing list