[webkit-reviews] review granted: [Bug 221680] [iOS][FCR] Add reduced motion animation for indeterminate progress bars : [Attachment 419855] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 10 09:28:47 PST 2021
Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 221680: [iOS][FCR] Add reduced motion animation for indeterminate progress
bars
https://bugs.webkit.org/show_bug.cgi?id=221680
Attachment 419855: Patch
https://bugs.webkit.org/attachment.cgi?id=419855&action=review
--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 419855
--> https://bugs.webkit.org/attachment.cgi?id=419855
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=419855&action=review
> Source/WebCore/rendering/RenderThemeIOS.mm:2217
> + context.fillRoundedRect(FloatRoundedRect(barRect, barCornerRadii),
controlColor.colorWithAlphaByte(alpha * 255.0f));
Nit - could we just use `colorWithAlpha(alpha)` instead?
More information about the webkit-reviews
mailing list