[webkit-reviews] review granted: [Bug 221649] [watchOS] Adopt PUICQuickboardController for text input : [Attachment 419816] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 9 23:17:26 PST 2021

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 221649: [watchOS] Adopt PUICQuickboardController for text input

Attachment 419816: Patch


--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 419816
  --> https://bugs.webkit.org/attachment.cgi?id=419816

View in context: https://bugs.webkit.org/attachment.cgi?id=419816&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6569
> +    // establishes a connection to the quickboard view service before
presenting the remote view controller.

I wonder if quickboard is a proper noun or a daemon name (should it be
capitalized or not?)

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:52

Technically would be better if these were all HAVE(PEPPER_UI_CORE) (at least, I
think that is the right direction for Sam's PLATFORM eradication project), but
this is fine for now.

More information about the webkit-reviews mailing list