[webkit-reviews] review granted: [Bug 221535] Reduce the overhead of DocumentFragment in innerHTML & outerHTML : [Attachment 419802] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 221535: Reduce the overhead of DocumentFragment in innerHTML & outerHTML
https://bugs.webkit.org/show_bug.cgi?id=221535

Attachment 419802: Patch

https://bugs.webkit.org/attachment.cgi?id=419802&action=review




--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 419802
  --> https://bugs.webkit.org/attachment.cgi?id=419802
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419802&action=review

r=me

> Source/WTF/wtf/WeakPtr.h:180
> +    bool hasWeakReferences() const { return m_impl; }

I would call this isInitialized().

Knowing that m_impl is non-null only tells us that someone created a reference
at some point - not that the reference still exists.