[webkit-reviews] review granted: [Bug 221555] PCM: expired reports get sent at the same time after a session restart : [Attachment 419795] Patch

[bugzilla-daemon at webkit.org]

John Wilander <wilander at apple.com> has granted katherine_cheney at apple.com's
request for review:
Bug 221555: PCM: expired reports get sent at the same time after a session
restart
https://bugs.webkit.org/show_bug.cgi?id=221555

Attachment 419795: Patch

https://bugs.webkit.org/attachment.cgi?id=419795&action=review




--- Comment #23 from John Wilander <wilander at apple.com> ---
Comment on attachment 419795
  --> https://bugs.webkit.org/attachment.cgi?id=419795
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419795&action=review

I think we arrived at a neat and simple solution. r=me, bar EWS and the two
minor comments.

> Source/WebKit/ChangeLog:1
> +2021-02-08  Kate Cheney  <katherine_cheney at apple.com>

Nit: We've discussing this one so long that it's now Feb 9th. :) Maybe the cq
takes care of that? I've never checked.

> Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:233
> +	       // Attributions are sorted by earliestTimeToSend, so the first
time we hit this will always be the min value of nextTimeToFire.

I think I understand what you're saying here but maybe it can be said more
clearly? I'm thinking "... the first time we hit this we know there can be no
further attributions due for reporting."