[webkit-reviews] review granted: [Bug 221627] Use CompletionHandler instead of ApplicationManifestCallback : [Attachment 419760] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 221627: Use CompletionHandler instead of ApplicationManifestCallback
https://bugs.webkit.org/show_bug.cgi?id=221627

Attachment 419760: Patch

https://bugs.webkit.org/attachment.cgi?id=419760&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 419760
  --> https://bugs.webkit.org/attachment.cgi?id=419760
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419760&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.h:2184
> +    HashMap<uint64_t, CompletionHandler<void(const
Optional<WebCore::ApplicationManifest>&)>>
m_applicationManifestFetchCallbackMap;

Now that you are storing CompletionHandlers in a data member, you may need to
do something in the WebPage destructor to make sure all remaining completion
handlers are called before destruction. Otherwise, you may end up with debug
assertion hits in some cases.