[webkit-reviews] review granted: [Bug 221396] RemoteGraphicsContextGLProxy should support losing the context and should lose the context on timeouts : [Attachment 419701] rebase

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 221396: RemoteGraphicsContextGLProxy should support losing the context and
should lose the context on timeouts
https://bugs.webkit.org/show_bug.cgi?id=221396

Attachment 419701: rebase

https://bugs.webkit.org/attachment.cgi?id=419701&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 419701
  --> https://bugs.webkit.org/attachment.cgi?id=419701
rebase

View in context: https://bugs.webkit.org/attachment.cgi?id=419701&action=review

> Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:59
> +    send(Messages::RemoteGraphicsContextGLProxy::WasCreated(true,
extensions, requestableExtensions), m_graphicsContextGLIdentifier);

What does the 'true' mean?

> Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:182
> +    // Skip messages intended for already removed messageReceiverMap()
destinations.
> +#if ENABLE(WEBGL)
> +    if (decoder.messageReceiverName() ==
Messages::RemoteGraphicsContextGLProxy::messageReceiverName())
> +	   return true;
> +#endif

This seems pretty unusual. Do we do this elsewhere?

> Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:357
> +    void disconnectGpuProcessIfNeeded();
> +    void abandonGpuProcess();

What's the difference between these? What does "abandon" imply?

>
Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGene
rated.cpp:39
> +    if (!isContextLost()) {
> +	   auto sendResult =
send(Messages::RemoteGraphicsContextGL::SetFailNextGPUStatusCheck());
> +	   if (!sendResult)
> +	       markContextLost();
> +    }

There's lot of boilerplate here. I wonder if we can factor this to avoid future
mistakes where we forget to check context lost.