[webkit-reviews] review granted: [Bug 221573] [LFC][Integration] Style change on an inline box should trigger invalidation : [Attachment 419626] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 8 22:12:21 PST 2021

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 221573: [LFC][Integration] Style change on an inline box should trigger

Attachment 419626: Patch


--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 419626
  --> https://bugs.webkit.org/attachment.cgi?id=419626

View in context: https://bugs.webkit.org/attachment.cgi?id=419626&action=review

> Source/WebCore/rendering/RenderInline.cpp:200
> +	   if (needsLayout()) {

Probably selfNeedsLayout()

We may also need descendant canUse test similar to canUseForAfterStyleChange.

> Source/WebCore/rendering/RenderInline.cpp:202
> +	      

There is LineLayout::blockContainer I have been using for this sort of things.

More information about the webkit-reviews mailing list