[webkit-reviews] review granted: [Bug 221591] Add API to disable HTTPS upgrade : [Attachment 419669] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 221591: Add API to disable HTTPS upgrade
https://bugs.webkit.org/show_bug.cgi?id=221591

Attachment 419669: Patch

https://bugs.webkit.org/attachment.cgi?id=419669&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 419669
  --> https://bugs.webkit.org/attachment.cgi?id=419669
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419669&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.h:134
> +/*! @abstract A Boolean value indicating whether HTTP requests to servers
known to support HTTPS should be automatically upgraded to HTTPS requests.
> + @discussion The default value is YES.
> + */
> + at property (nonatomic) BOOL upgradeCommonKnownRequestsToHTTPS
WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

This property should probably go through API review.

I think "upgradeKnownHostsToHTTPS" might be a better name. I removed "Common"
because common is not an clear threshold, and probably not the salient part of
the feature. I changed "Requests" to "Hosts" because the feature is per-host.

This will get a little awkward if we ever offer API to disable HSTS. Oh well.