[webkit-reviews] review denied: [Bug 221555] PCM: expired reports get sent at the same time after a session restart : [Attachment 419619] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied katherine_cheney at apple.com's request
for review:
Bug 221555: PCM: expired reports get sent at the same time after a session
restart
https://bugs.webkit.org/show_bug.cgi?id=221555

Attachment 419619: Patch

https://bugs.webkit.org/attachment.cgi?id=419619&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 419619
  --> https://bugs.webkit.org/attachment.cgi?id=419619
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419619&action=review

> Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:198
> +	   return;

BUG: CompletionHandler is not called...

> Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:206
> +#endif

#else
you need to call the completion handler..

> Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:252
> +    auto expiredAttribution = m_expiredAttributions.takeFirst();

We don't need this local variable.