[webkit-reviews] review granted: [Bug 221572] [iOS][FCR] Use UIColorPickerViewController for color inputs : [Attachment 419620] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 221572: [iOS][FCR] Use UIColorPickerViewController for color inputs
https://bugs.webkit.org/show_bug.cgi?id=221572

Attachment 419620: Patch

https://bugs.webkit.org/attachment.cgi?id=419620&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 419620
  --> https://bugs.webkit.org/attachment.cgi?id=419620
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419620&action=review

>>> Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm:73
>>> +- (UIColor *)colorFromHexString:(NSString *)string
>> 
>> Interesting. Do we not have a shared way to do this? Is this special because
it only supports a specific format? How sad is Sam that the colorspace is not
adjustable? :)
> 
> We have parseSimpleColorValue in ColorInputType in WebCore, but that would
involve String -> Color -> CGColor -> UIColor, as well as a new WEBCORE_EXPORT.
> 
> I added this method to go straight to UIColor, which I don't think we have a
shared way of doing. Do you think it's better to just use the WebCore method?
> 
> On another note, https://github.com/whatwg/html/issues/3400 is an open issue
on adding other colorspaces to <input type=color>.

I think you should see if weinig has opinions about the parsing