[webkit-reviews] review granted: [Bug 177803] Fix MSVC build with ENCRYPTED_MEDIA enabled : [Attachment 419609] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 177803: Fix MSVC build with ENCRYPTED_MEDIA enabled
https://bugs.webkit.org/show_bug.cgi?id=177803

Attachment 419609: Patch

https://bugs.webkit.org/attachment.cgi?id=419609&action=review




--- Comment #21 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 419609
  --> https://bugs.webkit.org/attachment.cgi?id=419609
Patch

The original patch introduced some unused lambda capture 'this' instances:

error:
.../OpenSource/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:
357:10: error: lambda capture 'this' is not used
[-Werror,-Wunused-lambda-capture]
.../OpenSource/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:
461:10: error: lambda capture 'this' is not used
[-Werror,-Wunused-lambda-capture]
.../OpenSource/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:
505:10: error: lambda capture 'this' is not used
[-Werror,-Wunused-lambda-capture]

What a great reason to delay this patch for 3.5 years.	This version doesn't
touch that file, so it should be fine.	If you want to also change
CDMClearKey.cpp, just remove 'this' if you can.