[webkit-reviews] review granted: [Bug 197744] Implement scroll-snap-stop for scroll snapping : [Attachment 419116] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 8 09:13:55 PST 2021
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 197744: Implement scroll-snap-stop for scroll snapping
https://bugs.webkit.org/show_bug.cgi?id=197744
Attachment 419116: Patch
https://bugs.webkit.org/attachment.cgi?id=419116&action=review
--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 419116
--> https://bugs.webkit.org/attachment.cgi?id=419116
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=419116&action=review
> Source/WebCore/ChangeLog:9
> + No new tests.
Please add some words here, with a link to the spec, and list which WPT test
the feature.
> Source/WebCore/rendering/RenderLayerModelObject.cpp:204
> + bool scrollSnapStopChanged =
> + oldStyle && oldStyle->scrollSnapStop() != newStyle.scrollSnapStop();
Don't wrap this.
More information about the webkit-reviews
mailing list