[webkit-reviews] review granted: [Bug 221267] WebXRSystem::RequestSession with 'viewer' as a required feature should succeed : [Attachment 419017] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 8 07:22:09 PST 2021


Sergio Villar Senin <svillar at igalia.com> has granted Imanol Fernandez
<ifernandez at igalia.com>'s request for review:
Bug 221267: WebXRSystem::RequestSession with 'viewer' as a required feature
should succeed
https://bugs.webkit.org/show_bug.cgi?id=221267

Attachment 419017: Patch

https://bugs.webkit.org/attachment.cgi?id=419017&action=review




--- Comment #2 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 419017
  --> https://bugs.webkit.org/attachment.cgi?id=419017
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419017&action=review

> Source/WebCore/Modules/webxr/WebXRSystem.cpp:211
> +	       auto feature =
parseEnumeration<XRReferenceSpaceType>(*globalObject.document()->globalObject()
, features.first());

I guess you can directly use the document parameter instead of retrieving it
from the DOMWindow.

> LayoutTests/ChangeLog:8
> +	   * platform/wpe/TestExpectations:

Nit: just add something like "marked a test as passing" or something like that.


More information about the webkit-reviews mailing list